Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list replica sets & replication controllers (#650) #651

Merged
merged 1 commit into from
Aug 16, 2023
Merged

list replica sets & replication controllers (#650) #651

merged 1 commit into from
Aug 16, 2023

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Aug 15, 2023 •
edited
Loading

fixes #650

both "Replication Controllers" and "Replica Sets" are now listed with their pods:
image

@adietish adietish self-assigned this Aug 15, 2023
@adietish adietish requested a review from sbouchet August 15, 2023 18:57
@adietish adietish force-pushed the issue-650 branch 3 times, most recently from d9e13b9 to de4df98 Compare August 15, 2023 19:38
@adietish adietish changed the title list replica sets (#650) list replica sets & replication controllers (#650) Aug 15, 2023
@adietish adietish force-pushed the issue-650 branch 3 times, most recently from fc9bbc8 to be63366 Compare August 16, 2023 12:18
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sbouchet
sbouchet approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. can apply replicaset /replicacontroller yaml to kubernets cluster, edit them and push changes to cluster without issues

@adietish
Copy link
Collaborator Author

@sbouchet awesome, thanks for reviewing.

@adietish adietish merged commit 8354bc8 into redhat-developer:main Aug 16, 2023
15 checks passed
@adietish adietish deleted the issue-650 branch August 16, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a user I want to have Replica Sets and Replication Controllers listed in the resource tree
2 participants
@adietish @sbouchet