Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor: bump kubernetes-client to 6.12.0 (#713) #730

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Mar 20, 2024

@adietish adietish self-assigned this Mar 20, 2024
@adietish adietish changed the title bump kubernetes-client to 6.10 (#713) refactor: bump kubernetes-client to 6.10 (#713) Mar 20, 2024
@adietish adietish force-pushed the issue-713 branch 2 times, most recently from bdc7db6 to 02f4931 Compare March 20, 2024 15:40
@adietish adietish force-pushed the issue-713 branch 4 times, most recently from 0439a63 to d61c751 Compare April 10, 2024 13:56
@adietish adietish changed the title refactor: bump kubernetes-client to 6.10 (#713) refactor: bump kubernetes-client to latest (most likely 6.11.1) (#713) Apr 10, 2024
@adietish adietish changed the title refactor: bump kubernetes-client to latest (most likely 6.11.1) (#713) refactor: bump kubernetes-client to 6.11.1 (#713) Apr 10, 2024
@mohitsuman
Copy link
Collaborator

Should this be still in draft ?

@adietish
Copy link
Collaborator Author

Should this be still in draft ?

Yes because it depends on intellij-common to be bumped to the same client and released (1.9.4)

@adietish adietish changed the title refactor: bump kubernetes-client to 6.11.1 (#713) refactor: bump kubernetes-client to 6.12.0 (#713) Apr 12, 2024
@adietish adietish requested a review from sbouchet April 15, 2024 09:46
@adietish adietish marked this pull request as ready for review April 15, 2024 09:49
@adietish adietish changed the title refactor: bump kubernetes-client to 6.12.0 (#713) fix: refactor: bump kubernetes-client to 6.12.0 (#713) Apr 15, 2024
@adietish
Copy link
Collaborator Author

adietish commented Apr 15, 2024

Even though this seems to compiles fine it will fail at runtime with a different kubernetes-client being available from intellij-common. We need to wait for intellij-common 1.9.4 to be available from repository.jboss.org

Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update commons version

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adietish
Copy link
Collaborator Author

adietish commented Apr 16, 2024

@sbouchet: updated to latest intellij-common. Please re-review

ps. error in ITs can be ignored, they need upgrade to latest IC

Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please open an issue tio fix those failling tests

@adietish adietish merged commit c996c6c into redhat-developer:main Apr 16, 2024
12 of 13 checks passed
@adietish adietish deleted the issue-713 branch April 16, 2024 13:57
@adietish
Copy link
Collaborator Author

LGTM. please open an issue tio fix those failling tests

done in #746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump kuberntes-client to latest kubernetes-client (6.12.0)
3 participants