Skip to content
This repository has been archived by the owner on Nov 11, 2024. It is now read-only.

apply --dryrun no longer uses 'true' or 'false'. Instead it uses 'non… #325

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeffgus
Copy link

@jeffgus jeffgus commented Sep 22, 2022

…e', 'client', and 'server'.

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2022

Hi @jeffgus. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chetan-rns
Copy link
Member

/ok-to-test

@jeffgus
Copy link
Author

jeffgus commented Sep 23, 2022

It is unclear to me why the bootstrap command would cause a failure. The code change is only changes what strings are written out to two files.

@jeffgus jeffgus mentioned this pull request Mar 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wtam2018 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2023

@jeffgus: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit a78f546 link true /test unit
ci/prow/v4.9-integration-e2e a78f546 link true /test v4.9-integration-e2e
ci/prow/v4.10-integration-e2e a78f546 link true /test v4.10-integration-e2e
ci/prow/v4.8-integration-e2e a78f546 link true /test v4.8-integration-e2e
ci/prow/v4.13-integration-e2e a78f546 link true /test v4.13-integration-e2e
ci/prow/v4.11-integration-e2e a78f546 link true /test v4.11-integration-e2e
ci/prow/v4.12-integration-e2e a78f546 link true /test v4.12-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants