fix: Added support for non-standard member token type reported by the TypeScript language server for static methods
#692
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g syntax-highlighted properly. After digging in, it's because they're being reported as non-standard token type "member" instead of "method". This addresses that omission and also creates a more formal way to add non-standard token types.
SCWells72
changed the title
static methodsmember token type reported by the TypeScript language server for static methods
|
@SCWells72 I understand that the result is very nice, but I would like to really avoid hard code custom token for each language server. My idea for user defined language server is to have
|
|
I see that you rebase your PR but as I have tried to explain, I would like to have a more generic support to do that like vscode provides. Hope you will understand. |
Oh, I'm just rebasing all open branches to keep things fresh for when I return to them. I'm not actively working on these right now. I'll change this to a draft PR to prevent any further confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably best demonstrated visually. Here's the syntax highlighting without this fix:
and here it is with this fix:
Note the lack of highlighting for the declaration and usage of
staticmethoddemoin the first image and the proper highlighting of both in the second image.