Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added vscode-vue-js-language-template for windows #715

Conversation

welcome-day
Copy link
Contributor

add vscode-vue-js-language-server for windows

@welcome-day
Copy link
Contributor Author

#710

@welcome-day welcome-day changed the title add vscode-vue-js-language-template for windows feat: Added vscode-vue-js-language-template for windows Dec 19, 2024
@angelozerr
Copy link
Contributor

Thanks @welcome-day !

I wonder if it should be better to instalk language server just with npm?

It will avoid having a vscode dependency?

We could have 2 sections in the readme

With vscode like you have explained and without vscode by using npm

If it works with npm I think template should use this strategy.

Is it possible also to update the markdown doc pages by adding a new markdown page in the doc folder (just copy paste your readme and add a little demo?) And refzrence this page in the user defined ls page.

If you have no time to do that please tell me.

I will see also to generate json schema for the configuration editor.

@welcome-day
Copy link
Contributor Author

Thanks @welcome-day !

I wonder if it should be better to instalk language server just with npm?

It will avoid having a vscode dependency?

We could have 2 sections in the readme

With vscode like you have explained and without vscode by using npm

If it works with npm I think template should use this strategy.

Is it possible also to update the markdown doc pages by adding a new markdown page in the doc folder (just copy paste your readme and add a little demo?) And refzrence this page in the user defined ls page.

If you have no time to do that please tell me.

I will see also to generate json schema for the configuration editor.

Hi! Please, see: 4ea3240

"id": "vue-js-language-server",
"name": "Vue.js Language Server",
"programArgs": {
"windows": "vue-language-server.cmd --stdio",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.cmd is required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. ".cmd" required
in my case on windows 10 lsp not started, plugin throw exception

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks for your feedbzck, that is strange. Could yiu remove .cmd for default because it is for other os than windows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I make later

Copy link
Contributor

@angelozerr angelozerr Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have no time to do that I could merge it and fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have no time to do that I could merge it and fix it.

c1047ef

Done.

@angelozerr angelozerr merged commit d878977 into redhat-developer:main Dec 23, 2024
1 check passed
@angelozerr
Copy link
Contributor

Thanks so much @welcome-day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants