Configure other than Backstage container to mount PVC volume to #582
Conversation
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
gazarenkov
changed the title
docs/configuration.md
Outdated
| @@ -56,6 +56,28 @@ metadata: | |||
|
|
|||
| In the example above the PVC called **myclaim** will be mounted to **/mount/path/from/annotation** directory | |||
|
|
|||
| #### Object annotation for mounting a volume to specific container(s) | |||
|
|
|||
| Using **rhdh.redhat.com/containers** annotation it is possible to define the containers where **PersistentVolumeClaim** object will be mounted. | |||
There was a problem hiding this comment.
This implies that the mount path will be the same in all the containers listed here, right?
What if I want to mount the PVC under specific paths for each container? IMO, we should handle this.
Thinking out loud, but how about extending the behavior of the rhdh.redhat.com/mount-path annotation above to include the container names, e.g.: rhdh.redhat.com/mount-path: 'install-dynamic-plugins:/mount/path1,backstage-backend:/mount/path2'?
There was a problem hiding this comment.
Thought about it (and discussed with Tomas)... Can not see the case when it should be really important for default configuration. We can (and will when needed) make it more flexible for CR but I'd really avoid scripting in annotations unless really unavoidable.
|
/assign |
Signed-off-by: gazarenkov <[email protected]>
Signed-off-by: gazarenkov <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue(s) does this PR fix or relate to
https://issues.redhat.com/browse/RHIDP-4595
PR acceptance criteria
rhdh-operator.clusterserviceversion.yamlfile accordingly