Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metadata): ensure build metadata is up-to-date #1008

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

schultzp2020
Copy link
Collaborator

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@schultzp2020 schultzp2020 requested a review from a team as a code owner February 26, 2024 19:27
@openshift-ci openshift-ci bot requested review from tumido and Zaperex February 26, 2024 19:27
Copy link

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1008!

Signed-off-by: Paul Schultz <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Feb 26, 2024
Copy link

openshift-ci bot commented Feb 26, 2024

New changes are detected. LGTM label has been removed.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1008!

@nickboldt nickboldt merged commit 91ad5d6 into main Feb 26, 2024
5 of 7 checks passed
@nickboldt nickboldt deleted the rhidp-1414 branch February 26, 2024 20:44
@nickboldt
Copy link
Member

/cherry-pick 1.1.x

@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: new pull request created: #1009

In response to this:

/cherry-pick 1.1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants