Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test infra] Remove unused code #1010

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

josephca
Copy link
Contributor

@josephca josephca commented Feb 26, 2024

Description

Clean up unused code. ${TAG_NAME} is passed from the CI. This fixes a failure when triggering tests manually

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@josephca josephca requested a review from a team as a code owner February 26, 2024 22:00
Copy link

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from josephca. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@josephca josephca requested review from gustavolira and subhashkhileri and removed request for nickboldt and a team February 26, 2024 22:03
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1010!

Copy link
Contributor

janus-idp bot commented Feb 26, 2024

backstage-showcase Tests on commit finished with errors.
View test log

@josephca josephca merged commit 41d9f3d into redhat-developer:main Feb 27, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant