Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to backstage 1.23.3 #1014

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore(deps): update to backstage 1.23.3 #1014

merged 1 commit into from
Feb 27, 2024

Conversation

schultzp2020
Copy link
Collaborator

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@schultzp2020 schultzp2020 requested a review from a team as a code owner February 26, 2024 23:15
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@schultzp2020
Copy link
Collaborator Author

@nickboldt We will need to backport this to 1.1. We will also need to update build-metadata.json to say RHDH Version: 1.1.0 instead of RHDH Version: 1.2.0.

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1014!

Copy link
Contributor

janus-idp bot commented Feb 27, 2024

backstage-showcase Tests on commit finished with errors.
View test log

Copy link

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt
Copy link
Member

/cherry-pick 1.1x

@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: once the present PR merges, I will cherry-pick it on top of 1.1x in a new PR and assign it to you.

In response to this:

/cherry-pick 1.1x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nickboldt nickboldt merged commit 816c155 into main Feb 27, 2024
5 of 8 checks passed
@nickboldt nickboldt deleted the backstage-1.23.3 branch February 27, 2024 01:51
@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: cannot checkout 1.1x: error checking out "1.1x": exit status 1 error: pathspec '1.1x' did not match any file(s) known to git

In response to this:

/cherry-pick 1.1x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nickboldt
Copy link
Member

/cherry-pick 1.1.x

@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: #1014 failed to apply on top of branch "1.1.x":

Applying: chore(deps): update to backstage 1.23.3
Using index info to reconstruct a base tree...
M	packages/app/package.json
M	yarn.lock
Falling back to patching base and 3-way merge...
Auto-merging yarn.lock
Auto-merging packages/app/package.json
CONFLICT (content): Merge conflict in packages/app/package.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 chore(deps): update to backstage 1.23.3
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick 1.1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nickboldt pushed a commit that referenced this pull request Feb 27, 2024
nickboldt added a commit that referenced this pull request Feb 27, 2024
…ps): update to backstage 1.23.3; chore(deps): RHIDP-1435 update to sanitize-html @ 2.12.1 (#1019)

* chore(deps): RHIDP-1435 update to sanitize-html @ 2.12.1

Signed-off-by: Nick Boldt <[email protected]>

* chore(deps): update to backstage 1.23.3 (#1014)

Signed-off-by: Paul Schultz <[email protected]>

* fix(admin): added RBAC tab display condition (#989)

* fix(admin): added RBAC tab display condition

Signed-off-by: Yi Cai <[email protected]>

* Updates for comments

Signed-off-by: Yi Cai <[email protected]>

* Added yarn.lock

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>

* Update packages/app/src/build-metadata.json

---------

Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Paul Schultz <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Co-authored-by: Paul Schultz <[email protected]>
Co-authored-by: Yi Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants