Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove janus links from homepage #2243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

04kash
Copy link
Collaborator

@04kash 04kash commented Jan 23, 2025

Description

Remove the "Community" Section in the homepage.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@04kash 04kash force-pushed the update-homepage-data branch from c1d1306 to b84509e Compare January 23, 2025 18:57
@04kash 04kash requested a review from BethGriggs January 23, 2025 18:58
@04kash 04kash force-pushed the update-homepage-data branch 2 times, most recently from e2a4a2f to d7670f3 Compare January 23, 2025 19:26
Copy link
Contributor

@04kash 04kash marked this pull request as draft January 24, 2025 15:25
@04kash 04kash marked this pull request as ready for review January 24, 2025 16:38
@04kash 04kash force-pushed the update-homepage-data branch from aa77743 to 21c624a Compare January 24, 2025 21:24
Copy link

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff
Once this PR has been reviewed and has the lgtm label, please ask for approval from 04kash. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

"url": "https://groups.google.com/g/janus-idp-community"
},
{
"iconUrl": "/homepage/icons/icons8/tear-off-calendar.png",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually is this icon still used anywhere?

Copy link
Contributor

Copy link

openshift-ci bot commented Jan 24, 2025

@04kash: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 21c624a link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants