RHIDP-1074 [Playwright tests] enable quay.spec.ts test #904

gustavolira · 2024-01-25T14:35:54Z

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

GitHub Actions are completed and successful
Unit Tests are updated and passing
E2E Tests are updated and passing
Documentation is updated if necessary (requirement for new features)
Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

changeset-bot · 2024-01-25T14:35:58Z

⚠️ No Changeset found

Latest commit: 25295c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-01-25T15:01:36Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-904!

janus-idp · 2024-01-25T15:13:01Z

backstage-showcase Tests on commit 0db0f65 finished with errors.
View test log

github-actions · 2024-01-25T17:15:23Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-904!

github-actions · 2024-01-25T18:16:01Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-904!

github-actions · 2024-01-25T19:22:49Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-904!

josephca

/lgtm
/approve

josephca · 2024-01-25T19:48:43Z

/lgtm

github-actions · 2024-01-25T20:05:12Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-904!

github-actions · 2024-02-11T22:44:27Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-904!

github-actions · 2024-02-11T23:24:21Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-904!

github-actions · 2024-02-12T00:08:12Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-904!

github-actions · 2024-02-12T00:42:18Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-904!

github-actions · 2024-02-19T22:43:14Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-904!

e2e-tests/playwright/utils/UIhelper.ts

e2e-tests/playwright.config.ts

subhashkhileri · 2024-02-20T14:34:13Z

e2e-tests/playwright/utils/UIhelper.ts

+        `${UIhelperPO.MuiTable} thead th >> text="${header}"`,
+      );
+      const count = await headerLocator.count();
+      expect(count).toBeGreaterThan(0);


Could we use toBeVisible instead? I believe it would accomplish the same thing while also ensuring visibility.

github-actions · 2024-02-20T15:01:39Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-904!

Signed-off-by: Gustavo Lira <[email protected]>

Make possible to disable html report Signed-off-by: Gustavo Lira <[email protected]> Signed-off-by: Gustavo Lira <[email protected]>

sonarqubecloud · 2024-02-21T20:07:35Z

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

josephca · 2024-02-21T20:14:27Z

/lgtm
/approve

openshift-ci · 2024-02-21T20:14:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~.ibm/OWNERS~~ [josephca]
~~e2e-tests/OWNERS~~ [josephca]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-actions · 2024-02-21T20:32:58Z

The image is available at: quay.io/janus-idp/backstage-showcase:pr-904!

openshift-ci bot added the do-not-merge/work-in-progress label Jan 25, 2024

gustavolira force-pushed the RHIDP-1074 branch 2 times, most recently from 7d622ae to 295de8c Compare January 25, 2024 16:40

openshift-merge-robot added the needs-rebase label Jan 25, 2024

gustavolira force-pushed the RHIDP-1074 branch from 295de8c to 453cbb0 Compare January 25, 2024 17:46

openshift-merge-robot removed the needs-rebase label Jan 25, 2024

gustavolira marked this pull request as ready for review January 25, 2024 18:24

gustavolira requested a review from a team as a code owner January 25, 2024 18:24

openshift-ci bot removed the do-not-merge/work-in-progress label Jan 25, 2024

openshift-ci bot requested review from josephca and rnapoles-rh January 25, 2024 18:24

josephca approved these changes Jan 25, 2024

View reviewed changes

openshift-ci bot assigned josephca Jan 25, 2024

openshift-ci bot added lgtm approved labels Jan 25, 2024

gustavolira force-pushed the RHIDP-1074 branch from 2b1497e to 4395e20 Compare January 25, 2024 19:37

openshift-ci bot removed the lgtm label Jan 25, 2024

openshift-ci bot added the lgtm label Jan 25, 2024

gustavolira force-pushed the RHIDP-1074 branch from 4395e20 to 1d97fe0 Compare February 9, 2024 13:59

openshift-ci bot removed lgtm approved labels Feb 9, 2024

openshift-merge-robot added the needs-rebase label Feb 9, 2024

gustavolira force-pushed the RHIDP-1074 branch from e3f8a26 to b7f3fcc Compare February 11, 2024 23:41

openshift-merge-robot removed the needs-rebase label Feb 11, 2024

gustavolira force-pushed the RHIDP-1074 branch from b7f3fcc to 38cc63f Compare February 12, 2024 00:16

gustavolira requested a review from josephca February 12, 2024 01:00

openshift-merge-robot added the needs-rebase label Feb 17, 2024

gustavolira force-pushed the RHIDP-1074 branch from 38cc63f to 2e0218e Compare February 19, 2024 22:07

openshift-merge-robot removed the needs-rebase label Feb 19, 2024

subhashkhileri reviewed Feb 20, 2024

View reviewed changes

e2e-tests/playwright/utils/UIhelper.ts Outdated Show resolved Hide resolved

subhashkhileri reviewed Feb 20, 2024

View reviewed changes

e2e-tests/playwright.config.ts Show resolved Hide resolved

gustavolira force-pushed the RHIDP-1074 branch 3 times, most recently from a9cca87 to 25295c4 Compare February 20, 2024 14:34

subhashkhileri requested changes Feb 20, 2024

View reviewed changes

openshift-ci bot assigned subhashkhileri Feb 20, 2024

gustavolira added 2 commits February 21, 2024 17:05

RHIDP-1074 [Playwright tests] enable quay.spec.ts test

7a0c690

Signed-off-by: Gustavo Lira <[email protected]>

Allow run e2e tests with insecure page

1923ab0

Make possible to disable html report Signed-off-by: Gustavo Lira <[email protected]> Signed-off-by: Gustavo Lira <[email protected]>

gustavolira force-pushed the RHIDP-1074 branch from 25295c4 to 1923ab0 Compare February 21, 2024 20:07

openshift-ci bot added the approved label Feb 21, 2024

openshift-ci bot added the lgtm label Feb 21, 2024

openshift-merge-bot bot merged commit 5fde1cd into redhat-developer:main Feb 21, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RHIDP-1074 [Playwright tests] enable quay.spec.ts test #904

RHIDP-1074 [Playwright tests] enable quay.spec.ts test #904

gustavolira commented Jan 25, 2024

changeset-bot bot commented Jan 25, 2024 •

edited by openshift-ci bot

Loading

github-actions bot commented Jan 25, 2024

janus-idp bot commented Jan 25, 2024 •

edited

Loading

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

josephca left a comment

josephca commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Feb 11, 2024

github-actions bot commented Feb 11, 2024

github-actions bot commented Feb 12, 2024

github-actions bot commented Feb 12, 2024

github-actions bot commented Feb 19, 2024

subhashkhileri Feb 20, 2024

github-actions bot commented Feb 20, 2024

sonarqubecloud bot commented Feb 21, 2024

josephca commented Feb 21, 2024

openshift-ci bot commented Feb 21, 2024

github-actions bot commented Feb 21, 2024

RHIDP-1074 [Playwright tests] enable quay.spec.ts test #904

RHIDP-1074 [Playwright tests] enable quay.spec.ts test #904

Conversation

gustavolira commented Jan 25, 2024

Description

Which issue(s) does this PR fix

PR acceptance criteria

How to test changes / Special notes to the reviewer

changeset-bot bot commented Jan 25, 2024 • edited by openshift-ci bot Loading

⚠️ No Changeset found

github-actions bot commented Jan 25, 2024

janus-idp bot commented Jan 25, 2024 • edited Loading

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

josephca left a comment

Choose a reason for hiding this comment

josephca commented Jan 25, 2024

github-actions bot commented Jan 25, 2024

github-actions bot commented Feb 11, 2024

github-actions bot commented Feb 11, 2024

github-actions bot commented Feb 12, 2024

github-actions bot commented Feb 12, 2024

github-actions bot commented Feb 19, 2024

subhashkhileri Feb 20, 2024

Choose a reason for hiding this comment

github-actions bot commented Feb 20, 2024

sonarqubecloud bot commented Feb 21, 2024

Quality Gate passed

josephca commented Feb 21, 2024

openshift-ci bot commented Feb 21, 2024

github-actions bot commented Feb 21, 2024

changeset-bot bot commented Jan 25, 2024 •

edited by openshift-ci bot

Loading

janus-idp bot commented Jan 25, 2024 •

edited

Loading