Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test log as an PR comment when backstage instance is not up/running #988

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

josephca
Copy link
Contributor

Description

When PR test fails in provisioning an RHDH instance, it needs to provide a more detailed error message and add a comment to the PR itself. Currently, test logs are added only when tests are started but not when failed in starting up the RHDH instance.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@josephca josephca requested a review from a team as a code owner February 20, 2024 21:02
@josephca
Copy link
Contributor Author

@subhashkhileri @gustavolira please review. Thanks!

@josephca josephca requested review from gustavolira and subhashkhileri and removed request for nickboldt and schultzp2020 February 20, 2024 21:05
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-988!

Copy link
Contributor

janus-idp bot commented Feb 20, 2024

backstage-showcase Tests on commit 07b8972 finished successfully.
View test log

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-988!

Copy link

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gustavolira
Once this PR has been reviewed and has the lgtm label, please ask for approval from josephca. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@josephca josephca merged commit b648b49 into redhat-developer:main Feb 21, 2024
5 of 7 checks passed
@josephca josephca deleted the detailedTestLog branch February 26, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants