fix(admin): added RBAC tab display condition #989
Conversation
Signed-off-by: Yi Cai <[email protected]>
|
The image is available at: |
|
/cc @gashcrumb |
ciiay
changed the title
|
Tests for this change will be handled in a separate PR. |
|
The image is available at: |
…c-tab-for-guest-users
|
|
The image is available at: |
|
/cherry-pick 1.1.x |
|
@nickboldt: only janus-idp org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
nickboldt
added
the
cherry-pick-1.1.x
|
Thanks @ciiay, verified the changes work as expected. did you missed to update |
Signed-off-by: Yi Cai <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gashcrumb, invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The image is available at: |
openshift-merge-bot
bot
merged commit b23f324
into
redhat-developer:main
|
/cherry-pick 1.1.x |
|
@nickboldt: new pull request created: #1018 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* fix(admin): added RBAC tab display condition Signed-off-by: Yi Cai <[email protected]> * Updates for comments Signed-off-by: Yi Cai <[email protected]> * Added yarn.lock Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
…ps): update to backstage 1.23.3; chore(deps): RHIDP-1435 update to sanitize-html @ 2.12.1 (#1019) * chore(deps): RHIDP-1435 update to sanitize-html @ 2.12.1 Signed-off-by: Nick Boldt <[email protected]> * chore(deps): update to backstage 1.23.3 (#1014) Signed-off-by: Paul Schultz <[email protected]> * fix(admin): added RBAC tab display condition (#989) * fix(admin): added RBAC tab display condition Signed-off-by: Yi Cai <[email protected]> * Updates for comments Signed-off-by: Yi Cai <[email protected]> * Added yarn.lock Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]> * Update packages/app/src/build-metadata.json --------- Signed-off-by: Nick Boldt <[email protected]> Signed-off-by: Paul Schultz <[email protected]> Signed-off-by: Yi Cai <[email protected]> Co-authored-by: Paul Schultz <[email protected]> Co-authored-by: Yi Cai <[email protected]>
Description
Guest users get empty RBAC content while permission not exists.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
*Unit test and e2e test will be handled in a separate PR.
How to test changes / Special notes to the reviewer
Login with both guest and GitHub users and observe RBAC tab for GitHub users.
Screen video
add_condition_to_display_rbac_tab.mov