Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e-test] Enhance loginAsGithubUser() to Handle Intermittent Pop-up Visibility Issues & Fix Quay test #995

Conversation

subhashkhileri
Copy link
Member

Description

[e2e-test] Enhance loginAsGithubUser() to Handle Intermittent Pop-up Visibility Issues

Which issue(s) does this PR fix

https://issues.redhat.com/browse/RHIDP-1396

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@subhashkhileri subhashkhileri requested a review from a team as a code owner February 22, 2024 11:01
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-995!

Copy link
Contributor

janus-idp bot commented Feb 22, 2024

backstage-showcase Tests on commit b108a33 finished successfully.
View test log

@subhashkhileri subhashkhileri force-pushed the login-popup-visibility-issue branch from 16b8ca5 to ab30651 Compare February 22, 2024 12:25
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@subhashkhileri subhashkhileri changed the title [e2e-test] Enhance loginAsGithubUser() to Handle Intermittent Pop-up Visibility Issues [e2e-test] Enhance loginAsGithubUser() to Handle Intermittent Pop-up Visibility Issues & Fix Quay test Feb 22, 2024
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-995!

Copy link
Contributor

@invincibleJai invincibleJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 347591c into redhat-developer:main Feb 22, 2024
7 checks passed
@nickboldt
Copy link
Member

Reminder that if you want changes like this in the 1.1.x branch, you have to cherrypick this change to that branch.

@subhashkhileri
Copy link
Member Author

@nickboldt I have raised PR for 1.1.x branch : #996

@nickboldt
Copy link
Member

/cherry-pick 1.1.x

@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: only janus-idp org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick 1.1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nickboldt
Copy link
Member

/cherry-pick 1.1.x

@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: new pull request created: #997

In response to this:

/cherry-pick 1.1.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants