-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e-test] Enhance loginAsGithubUser() to Handle Intermittent Pop-up Visibility Issues & Fix Quay test #995
[e2e-test] Enhance loginAsGithubUser() to Handle Intermittent Pop-up Visibility Issues & Fix Quay test #995
Conversation
…Visibility Issues Signed-off-by: Subhash Khileri <[email protected]>
The image is available at: |
…Visibility Issues Signed-off-by: Subhash Khileri <[email protected]>
16b8ca5
to
ab30651
Compare
Quality Gate passedIssues Measures |
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
347591c
into
redhat-developer:main
Reminder that if you want changes like this in the 1.1.x branch, you have to cherrypick this change to that branch. |
@nickboldt I have raised PR for 1.1.x branch : #996 |
/cherry-pick 1.1.x |
@nickboldt: only janus-idp org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick 1.1.x |
@nickboldt: new pull request created: #997 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
[e2e-test] Enhance loginAsGithubUser() to Handle Intermittent Pop-up Visibility Issues
Which issue(s) does this PR fix
https://issues.redhat.com/browse/RHIDP-1396
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer