Fix violations of Sonar rule 2755 #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable enough. I don't think these classes use any external schema or validation so shouldn't have any negative effect. |
|
Great! I'll probably be back with more automated fixes as we keep developing Sorald. Thanks for taking the time to review and merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes violations of Sonar rule 2755: "XML parsers should not be vulnerable to XXE attacks". It's related to issue #317.
The patch was generated automatically with the tool Sorald. For details on the fix applied here, please see Sorald's documentation on rule 2755.
Ps. I'm not a bot, so please do treat this like any other PR in regards to providing feedback :)