review comments were addressed

Signed-off-by: msivasubramaniaan <[email protected]>
redhat-developer · Mar 15, 2024 · cf32542 · cf32542
1 parent a1e8e73
commit cf32542
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -28,10 +28,10 @@ jobs:
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
       - name: Install dependencies
         run: |
-          npm install -g typescript "vsce" "ovsx"
+          npm install -g typescript "@vscode/vsce" "ovsx"
           npm install
           echo "EXT_VERSION=$(cat package.json | jq -r .version)" >> $GITHUB_ENV
       - name: Build And Run Unit Tests
@@ -47,14 +47,14 @@ jobs:
           jq --tab '.extensionDependencies += [ "ms-kubernetes-tools.vscode-kubernetes-tools" ]' package.json  > package.json.new
           mv package.json.new package.json
           node ./out/build/update-readme.js
-          vsce package -o vscode-knative-${{ env.EXT_VERSION }}-${GITHUB_RUN_NUMBER}-${target}.vsix
-          sha256sum *-${target}.vsix > vscode-knative-${{ env.EXT_VERSION }}-${GITHUB_RUN_NUMBER}-${target}.vsix.sha256
+          vsce package -o vscode-knative-${{ env.EXT_VERSION }}-${GITHUB_RUN_NUMBER}.vsix
+          sha256sum *.vsix > vscode-knative-${{ env.EXT_VERSION }}-${GITHUB_RUN_NUMBER}.vsix.sha256
           ls -lash *.vsix *.sha256
       - name: Upload VSIX Artifacts
         uses: actions/upload-artifact@v4
         with:
           name: vscode-knative
-          path: vscode-knative*-${{ env.EXT_VERSION }}-${{github.run_number}}*.vsix
+          path: vscode-knative-${{ env.EXT_VERSION }}-${{github.run_number}}.vsix
           if-no-files-found: error
       - name: Publish to GH Release Tab
         if: ${{ inputs.publishToMarketPlace == 'true' && inputs.publishToOVSX == 'true' }}
@@ -64,12 +64,12 @@ jobs:
           automatic_release_tag: "${{ env.EXT_VERSION }}"
           draft: true
           files: |
-            vscode-knative-${{ env.EXT_VERSION }}-${{github.run_number}}*.vsix
-            vscode-knative-${{ env.EXT_VERSION }}-${{github.run_number}}*.sha256
+            vscode-knative-${{ env.EXT_VERSION }}-${{github.run_number}}.vsix
+            vscode-knative-${{ env.EXT_VERSION }}-${{github.run_number}}.sha256
 
   release-job:
     if: ${{ inputs.publishToMarketPlace == 'true' || inputs.publishToOVSX == 'true' }}
-    environment: ${{ (inputs.publishToMarketPlace == 'true' || inputs.publishToOVSX == 'true') && 'release' || 'pre-release' }}
+    environment: ${{ (inputs.publishToMarketPlace == 'true' || inputs.publishToOVSX == 'true') && 'release' }}
     runs-on: ubuntu-latest
     needs: packaging-job
     steps:
@@ -86,10 +86,10 @@ jobs:
       - name: Download VSIX Artifacts
         uses: actions/download-artifact@v4
       - name: Publish to VS Code Marketplace
-        if: ${{ github.event_name == 'schedule' || inputs.publishToMarketPlace == 'true' }}
+        if: ${{ inputs.publishToMarketPlace == 'true' }}
         run: |
           vsce publish -p ${{ secrets.VSCODE_MARKETPLACE_TOKEN }} --packagePath vscode-knative/vscode-knative-${{ env.EXT_VERSION }}-${GITHUB_RUN_NUMBER}.vsix
       - name: Publish to OpenVSX Registry
-        if: ${{ github.event_name == 'schedule' || inputs.publishToOVSX == 'true' }}
+        if: ${{ inputs.publishToOVSX == 'true' }}
         run: |
           ovsx publish -p ${{ secrets.OVSX_MARKETPLACE_TOKEN }} --packagePath vscode-knative/vscode-knative-${{ env.EXT_VERSION }}-${GITHUB_RUN_NUMBER}.vsix