Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding create component from git UI test #3507

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

lgrossma
Copy link
Contributor

@lgrossma lgrossma commented Nov 1, 2023

see: #3068

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3538e1) 34.44% compared to head (237a1b0) 34.49%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3507      +/-   ##
==========================================
+ Coverage   34.44%   34.49%   +0.04%     
==========================================
  Files          81       81              
  Lines        5777     5787      +10     
  Branches     1156     1158       +2     
==========================================
+ Hits         1990     1996       +6     
- Misses       3787     3791       +4     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -23,7 +23,7 @@ jobs:
strategy:
matrix:
os: [macos-latest, windows-latest, ubuntu-latest]
node: [ '18' ]
node: [ '18.15.x' ]
Copy link
Contributor

@vrubezhny vrubezhny Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18.15.x doesn't look like is to install a latest version of Node.js 18 - do we have any limitations on Node.js version related to VSCode OS Tools and/or test?

Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see a question inline

@lgrossma
Copy link
Contributor Author

lgrossma commented Nov 3, 2023

@vrubezhny Yes, the VSCode extension tester used for UI tests does not work with higher node versions due to selenium incompatibility.

@vrubezhny
Copy link
Contributor

@vrubezhny Yes, the VSCode extension tester used for UI tests does not work with higher node versions due to selenium incompatibility.

@lgrossma Thanks! This probably was a reason why I couldn't update vscode ext. tester to 5.10.0 neither to 5.6.0.

Signed-off-by: Lukas Grossmann <[email protected]>
@lgrossma lgrossma marked this pull request as ready for review November 6, 2023 16:03
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and seems to be passing consistently on my computer

@datho7561 datho7561 merged commit 5035d60 into redhat-developer:main Nov 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants