-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding create component from git UI test #3507
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3507 +/- ##
==========================================
+ Coverage 34.44% 34.49% +0.04%
==========================================
Files 81 81
Lines 5777 5787 +10
Branches 1156 1158 +2
==========================================
+ Hits 1990 1996 +6
- Misses 3787 3791 +4 ☔ View full report in Codecov by Sentry. |
@@ -23,7 +23,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: [macos-latest, windows-latest, ubuntu-latest] | |||
node: [ '18' ] | |||
node: [ '18.15.x' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18.15.x doesn't look like is to install a latest version of Node.js 18 - do we have any limitations on Node.js version related to VSCode OS Tools and/or test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see a question inline
@vrubezhny Yes, the VSCode extension tester used for UI tests does not work with higher node versions due to selenium incompatibility. |
@lgrossma Thanks! This probably was a reason why I couldn't update vscode ext. tester to 5.10.0 neither to 5.6.0. |
Signed-off-by: Lukas Grossmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and seems to be passing consistently on my computer
see: #3068