Cannot login to existing cluster #3935 #4774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4774 +/- ##
===========================================
+ Coverage 32.37% 44.68% +12.30%
===========================================
Files 85 99 +14
Lines 6505 8113 +1608
Branches 1349 1706 +357
===========================================
+ Hits 2106 3625 +1519
- Misses 4399 4488 +89 ☔ View full report in Codecov by Sentry. |
The `openshiftToolkit.failOnBrokenKubeConfigEntry` (boolean) option is added with the default set to `false` in order to make Kube config loading more robust. If it's required to fully check the correctness of the Kube config on startup, users can set its value to `true`, so Kubernetes Client will throw errors if any. Fixes: redhat-developer#3935 Signed-off-by: Victor Rubezhny <[email protected]>
vrubezhny
force-pushed
the
fix-filter-errorneous-kube-config-entries
branch
from
782e8ea to
08362b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
openshiftToolkit.failOnBrokenKubeConfigEntry(boolean) option is added with thedefault set to
falsein order to make Kube config loading more robust.If it's required to fully check the correctness of the Kube config on startup, users can
set its value to
true, so Kubernetes Client will throw errors if any.Fixes: #3935