Add tests

redhat-developer · Nov 27, 2023 · ea747c2 · ea747c2
1 parent 5775823
commit ea747c2
Show file tree

Hide file tree

Showing 2 changed files with 77 additions and 3 deletions.
diff --git a/src/languageservice/services/yamlSelectionRanges.ts b/src/languageservice/services/yamlSelectionRanges.ts
@@ -49,6 +49,7 @@ export function getSelectionRanges(document: TextDocument, positions: Position[]
           }
           startOffset = newOffset;
         }
+
         // Allow equal for children to override
         if (!currentNode || startOffset >= currentNode.offset) {
           currentNode = node;
@@ -123,9 +124,10 @@ export function getSelectionRanges(document: TextDocument, positions: Position[]
   }
 
   function getTextFromOffsets(startOffset: number, endOffset: number): string {
-    const start = document.positionAt(startOffset);
-    const end = document.positionAt(endOffset);
-    return document.getText({ start, end });
+    return document.getText({
+      start: document.positionAt(startOffset),
+      end: document.positionAt(endOffset),
+    });
   }
 }
 

diff --git a/test/yamlSelectionRanges.test.ts b/test/yamlSelectionRanges.test.ts
@@ -64,6 +64,20 @@ key:
       { start: { line: 1, character: 0 }, end: { line: 3, character: 8 } },
     ]);
 
+    positions = [
+      {
+        line: 3,
+        character: 3,
+      },
+    ];
+    ranges = getSelectionRanges(document, positions);
+    expect(ranges.length).equal(positions.length);
+    expectSelections(ranges[0], [
+      { start: { line: 3, character: 2 }, end: { line: 3, character: 8 } },
+      { start: { line: 2, character: 2 }, end: { line: 3, character: 8 } },
+      { start: { line: 1, character: 0 }, end: { line: 3, character: 8 } },
+    ]);
+
     positions = [
       {
         line: 2,
@@ -78,6 +92,64 @@ key:
     ]);
   });
 
+  it('selection ranges for array of objects', () => {
+    const yaml = `
+times:
+  - second: 1
+    millisecond: 10
+  - second: 2
+    millisecond: 0
+    `;
+    let positions: Position[] = [
+      {
+        line: 4,
+        character: 0,
+      },
+    ];
+    const document = setupTextDocument(yaml);
+    let ranges = getSelectionRanges(document, positions);
+    expect(ranges.length).equal(positions.length);
+    expectSelections(ranges[0], [
+      { start: { line: 2, character: 2 }, end: { line: 5, character: 18 } },
+      { start: { line: 1, character: 0 }, end: { line: 5, character: 18 } },
+    ]);
+
+    positions = [
+      {
+        line: 5,
+        character: 2,
+      },
+    ];
+    ranges = getSelectionRanges(document, positions);
+    expect(ranges.length).equal(positions.length);
+    expectSelections(ranges[0], [
+      { start: { line: 4, character: 4 }, end: { line: 5, character: 18 } },
+      { start: { line: 2, character: 2 }, end: { line: 5, character: 18 } },
+      { start: { line: 1, character: 0 }, end: { line: 5, character: 18 } },
+    ]);
+  });
+
+  it('selection ranges for trailing spaces', () => {
+    const yaml = `
+key:
+  - 1
+  - 2   \t
+    `;
+    const positions: Position[] = [
+      {
+        line: 2,
+        character: 9,
+      },
+    ];
+    const document = setupTextDocument(yaml);
+    const ranges = getSelectionRanges(document, positions);
+    expect(ranges.length).equal(positions.length);
+    expectSelections(ranges[0], [
+      { start: { line: 2, character: 2 }, end: { line: 3, character: 9 } },
+      { start: { line: 1, character: 0 }, end: { line: 3, character: 9 } },
+    ]);
+  });
+
   it('selection ranges jump for "" \'\'', () => {
     const yaml = `
 - "word"