fix: Make the logic around last_count working
#106
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhutar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test mvp |
jhutar
force-pushed
the
fix6-retry-upload
branch
from
9d8bbf4
to
c169b16
Compare
|
/test mvp |
1 similar comment
|
/test mvp |
|
@jhutar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
jhutar
force-pushed
the
fix6-retry-upload
branch
from
c169b16
to
279f8e4
Compare
Did 2 changes here: First is the important one where I removed `&& [[ $last_count -ge 0 ]]` as that was blocking changing last_count, because it was initialized to -1. Now it should work as expected. Second I made sure warning is printed if we fail to obtain current count value.
jhutar
force-pushed
the
fix6-retry-upload
branch
from
279f8e4
to
8dba97c
Compare
Did 2 changes here:
First is the important one where I removed
&& [[ $last_count -ge 0 ]]as that was blocking changing last_count, because it was initialized to -1. Now it should work as expected.Second I made sure warning is printed if we fail to obtain current count value.