Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat+test: nic attribute modification #402

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

grafuls
Copy link
Collaborator

@grafuls grafuls commented Jul 3, 2024

FROM PR: #392
AUTHOR: @dominikvagner

connected to: #385

After extensive testing on my part and a joint investigation with @grafuls, this feature cannot be fully implemented in the current state of our lab, because of our iDRAC setup/versions.
Getting a list of attributes for specific NICs is working as it should along with getting information about a specific attribute. (The same way as we do it for BIOS attributes.)
Setting attributes though does not work, even if the somewhat incomplete feeling iDRAC documentation about this use case says it should for versions 5.x.x.x (testing was done against 5.10.50.0 as the newest version available to us).
Neither my attempt at solving this or the reference script from Dell works.
In our case the end-point accepting the setting of attributes shows no supported attributes to set.

The getting functionality was implemented and tested. The setting of attributes was made as a draft implementation supposed to completed in the future, when the environment will allow for it.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 92.93478% with 13 lines in your changes missing coverage. Please review.

Project coverage is 91.34%. Comparing base (5b4dbb8) to head (6f1df6c).
Report is 11 commits behind head on development.

Files Patch % Lines
src/badfish/main.py 92.93% 13 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #402      +/-   ##
===============================================
+ Coverage        91.21%   91.34%   +0.13%     
===============================================
  Files                5        5              
  Lines             2175     2358     +183     
===============================================
+ Hits              1984     2154     +170     
- Misses             191      204      +13     
Flag Coverage Δ
unittests 91.34% <92.93%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grafuls grafuls merged commit 7b1d692 into redhat-performance:development Jul 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants