Merge pull request #318 from reihl/change_when_according_best_practice

Remove curly braces from item and change to loop range
redhatci · May 28, 2024 · 85b33f9 · 85b33f9
2 parents 25a8aad + d0a419a
commit 85b33f9
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/roles/node_prep/tasks/10_validation.yml b/roles/node_prep/tasks/10_validation.yml
@@ -486,12 +486,12 @@
       add_host:
         groups: dell_hosts_redfish
         hostname: "{{ chassis_result.results[item|int].item }}"
-      with_sequence: start=0 end="{{ numworkers|int + nummasters|int - 1 }}"
+      loop: "{{ range(0, numworkers|int + nummasters|int, 1)|list }}"
       when:
-        - not chassis_result.results[{{ item }}].failed|bool
-        - not firmware_result.results[{{ item }}].failed|bool
-        - "'Dell' in chassis_result.results[{{ item }}].redfish_facts.chassis.entries[0].Manufacturer"
-        - firmware_result.results[{{ item }}].redfish_facts.firmware.entries | json_query(query) | max >= "4.20.20.20"
+        - not chassis_result.results[item].failed|bool
+        - not firmware_result.results[item].failed|bool
+        - "'Dell' in chassis_result.results[item].redfish_facts.chassis.entries[0].Manufacturer"
+        - firmware_result.results[item].redfish_facts.firmware.entries | json_query(query) | max >= "4.20.20.20"
       vars:
         query: "[?Name=='Integrated Dell Remote Access Controller'].Version"
       register: dell_host_redfish_result
@@ -509,11 +509,11 @@
       add_host:
         groups: hp_hosts_redfish
         hostname: "{{ chassis_result.results[item|int].item }}"
-      with_sequence: start=0 end="{{ numworkers|int + nummasters|int - 1 }}"
+      loop: "{{ range(0, numworkers|int + nummasters|int, 1)|list }}"
       when:
-        - not chassis_result.results[{{ item }}].failed|bool
-        - not firmware_result.results[{{ item }}].failed|bool
-        - "'HPE' in chassis_result.results[{{ item }}].redfish_facts.chassis.entries[0].Manufacturer"
+        - not chassis_result.results[item].failed|bool
+        - not firmware_result.results[item].failed|bool
+        - "'HPE' in chassis_result.results[item].redfish_facts.chassis.entries[0].Manufacturer"
       register: hp_host_redfish_result
       retries: 6 # 1 minute (10 * 6)
       delay: 10 # Every 10 seconds