Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nmcli module to exclusion list #466

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Add nmcli module to exclusion list #466

merged 1 commit into from
Oct 14, 2024

Conversation

tonyskapunk
Copy link
Contributor

@tonyskapunk tonyskapunk commented Oct 14, 2024

SUMMARY

The nmcli module requires considerable work on documentation, current tests are failing due to this, since no work is expected for some time, I'm removing it from being evaluated.

Fixes the issue reported in:

The upstream commit that modifies the change is: ansible/ansible@b3a6e66

ISSUE TYPE
  • Bug
Tests

Test-Hints: no-check

The nmcli module requires considerable work on documentation, current
tests are failing due to this, since no work is expected for some time,
I'm removing it from being evaluated.
@tonyskapunk tonyskapunk self-assigned this Oct 14, 2024
@tonyskapunk tonyskapunk requested a review from a team as a code owner October 14, 2024 21:07
@dcibot
Copy link
Collaborator

dcibot commented Oct 14, 2024

from change #466:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator

dcibot commented Oct 14, 2024

from change #466:

  • no check (not a code change)

Copy link

Copy link
Contributor

@thekad thekad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would like a follow-up item in the backlog to revisit this later down the road

@tonyskapunk tonyskapunk added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit a73a0d4 Oct 14, 2024
7 checks passed
@tonyskapunk tonyskapunk deleted the nmcli_ex branch October 14, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants