Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken behavior for Pub/Sub #217

Merged
merged 6 commits into from
Aug 9, 2023

Conversation

@supercaracal
Copy link
Member Author

supercaracal commented Aug 9, 2023

#test_sharded_pubsub_with_multiple_channels

SEGV occured if using hiredis. Ruby prevents race condition by GIL. Global Pub/Sub works fine.

@supercaracal supercaracal marked this pull request as ready for review August 9, 2023 10:56
@supercaracal supercaracal merged commit 8e91ad7 into redis-rb:master Aug 9, 2023
24 checks passed
@supercaracal supercaracal deleted the fix-pubsub-enbug branch August 9, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant