Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for most of the pubsub classes that did not have any #2808

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

tishun
Copy link
Collaborator

@tishun tishun commented Mar 28, 2024

Closes #2805

Make sure that:

  • [x ] You have read the contribution guidelines.
  • [x ] You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • [x ] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [x ] You submit test cases (unit or integration tests) that back your changes.

@tishun tishun self-assigned this Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.62%. Comparing base (43843bf) to head (347078e).
Report is 241 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2808      +/-   ##
============================================
- Coverage     78.71%   77.62%   -1.09%     
- Complexity     6786     7190     +404     
============================================
  Files           508      537      +29     
  Lines         22765    24376    +1611     
  Branches       2446     2603     +157     
============================================
+ Hits          17919    18922    +1003     
- Misses         3717     4253     +536     
- Partials       1129     1201      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tishun tishun merged commit 4fd64df into redis:main Mar 29, 2024
3 of 4 checks passed
@tishun tishun deleted the topic/tishun/issue-2805 branch March 29, 2024 07:45
@tishun tishun added the type: task A general task label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement unit tests for the PubSub commands
1 participant