feat: use DASH support using dash.js #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave dash.js another look, this PR adds dashboard using dash.js. It's probably best to either merge this pr or #179, but not both.
This is something I still don't like about DASH.js, it makes a partial content request for all resouces in the dash playlist when loading the player. It might be possible to tune this behaviour, but I haven't found a way to do that so please let me know if you do :)
The dash player loads whenever the video element scrolls into view, not just when you click play. Let me know if delayed player initialization is a hard requirement
This is again not a breaking change. USE_HLS should still work as previously. If you enable both then USE_DASH has preference