feat: rename bbox parameters #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: Make `--bounding-box` less ideosyncratic #18
This PR refactors 1. the data meta-model module interface 2. the default Facade-X data meta-model according to this interface 3. the GeoSPARQL output to be according to this interface (1) prepares for future modules by enabling more encapsulation of a module class. (2) improves the locality of the Facade-X output. That in turn makes it easier to make new modules based off the Facade-X module. (3) makes clearer how geometries are generated, when they're reprojected and how they're output.
fixes: Make `--bounding-box` less ideosyncratic #18
|
Something went terribly wrong with rebasing, I'mma give up and try again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: Make
--bounding-boxless ideosyncratic #18