build: run buf action only on triggers from within the repo #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build: add path
weeco
approved these changes
Sep 5, 2024
andrewhsu
requested changes
Sep 5, 2024
Co-authored-by: Andrew Hsu <[email protected]>
andrewhsu
approved these changes
Sep 6, 2024
Co-authored-by: Andrew Hsu <[email protected]>
|
The latest Buf updates on your PR. Results from workflow Buf CI / push-module (pull_request).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substitute for #1425.
Currently the this action fails on PRs from forks due to
aws-actions/configure-aws-credentialsworkflow which does not have access to secrets and vars in that context.This PR makes the GH Action conditional to only run on PRs from within branches, along with push to master.
This should cover most cases since normally the Console team should be updating the protos.
Exceptions are docs updates by docs team, or external contributions. But we can work around those cases or offer manual fixes.