Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileUpload Component #27

Merged
merged 50 commits into from
Aug 11, 2016
Merged

FileUpload Component #27

merged 50 commits into from
Aug 11, 2016

Conversation

JonatanSalas
Copy link
Member

@JonatanSalas JonatanSalas commented Aug 11, 2016

This PR adds the FileUpload feature #2. There are some things that needs to be done to get at 100% but actually this working well.

I keep it open since I have finished to add:

  • Modal to confirm delete on file
  • Consume status from service and show an alert or success message when uploading files

Then I will add the following things:

  • Avoid duplicated files
  • Modal to confirm delete on file
  • Provide a better way to customize styles
  • Extract styles from JS or use somethings like CSS in JS option
  • Consume status from service and show an alert or success message when uploading files
  • Auto upload behaviour (This will delete the upload button that we use now, this could be another component too)

jonisaa and others added 30 commits August 9, 2016 16:54
@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage decreased (-4.2%) to 25.532% when pulling dbb2b7b on experimental into a1f89bc on master.

@codecov-io
Copy link

codecov-io commented Aug 11, 2016

Current coverage is 23.82% (diff: 11.85%)

Merging #27 into master will decrease coverage by 4.28%

@@             master        #27   diff @@
==========================================
  Files            24         28     +4   
  Lines           377        512   +135   
  Methods          48         72    +24   
  Messages          0          0          
  Branches         61         85    +24   
==========================================
+ Hits            106        122    +16   
- Misses          271        390   +119   
  Partials          0          0          

Powered by Codecov. Last update a1f89bc...b2a9d18

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage decreased (-4.5%) to 25.21% when pulling 81e0c2b on experimental into a1f89bc on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.7%) to 25.0% when pulling 55637ea on experimental into a1f89bc on master.

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage decreased (-4.6%) to 25.105% when pulling 55637ea on experimental into a1f89bc on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 25.105% when pulling 55637ea on experimental into a1f89bc on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 25.105% when pulling b2a9d18 on experimental into a1f89bc on master.

@JonatanSalas JonatanSalas merged commit 630af11 into master Aug 11, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 25.105% when pulling 98f8533 on experimental into a1f89bc on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants