Search/filter command by pattern, function name, and effect type #21
Conversation
AlbertLucianto
commented
Jan 6, 2018
•
AlbertLucianto
commented
| type, | ||
| name: description.pattern | ||
| || description.channel | ||
| || description.action |
There was a problem hiding this comment.
sould be description.action.name ?
There was a problem hiding this comment.
Thanks for pointing it out. But, I wasn't sure with what are needed to be checked by the filter, because some of them have payload. So for now, I just made it as simple as possible. Do you think the filter better check for the payload including the keys and values as well?
| rootEffectIds={this.props.rootEffectIds} | ||
| filter={this.state.filter} | ||
| setFilterOptions={this.setFilterOptions} | ||
| /> |
There was a problem hiding this comment.
There is also another EffectView deep inside ActionView/Reactions/EffectView which shows a similar effect tree but only for those sagas that reacted to the selected action. Right now when selecting an action the app crashes because the deeply nested EffectView receive a null filter. So we should forward filter options from ActionView down to it
There was a problem hiding this comment.
Thanks for the review! I will fix it in the next PR.
|
@AlbertLucianto Were you interested in completing this PR? |
