Format all files #369
Format all files #369
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Can you leave the |
|
@timdorr sure. |
Add `.gitattributes` file to make line endings more consistent (reduxjs#363) Fix webpack 4 support by setting `target: es2017` for `redux.legacy-esm.js` (reduxjs#370) Revert "Run Prettier on all files" This reverts commit 39e8094. Run Prettier on all files Add `.gitattributes` file to make line endings more consistent (reduxjs#363)
aryaemami59
force-pushed
the
format-all-files
branch
from
05f625a
to
01a1e95
Compare
…format-all-files
| @@ -2,6 +2,5 @@ | |||
| "semi": false, | |||
| "singleQuote": true, | |||
| "tabWidth": 2, | |||
| "trailingComma": "none", | |||
There was a problem hiding this comment.
It looks like the vast majority of changes are related to this config change. What's the motivation? Just asking in case we can keep this to a less extensive set of changes.
There was a problem hiding this comment.
Staying consistent with the other repos. Since the plan was to eventually unify all their configs by having them use the shareable configs created in reduxjs/redux-toolkit#4138, I thought taking care of line endings/formatting issues in one PR would make things less unpredictable so you guys won't have to deal with a bunch of formatting changes in an unrelated PR in case somebody decides to run Prettier before pushing their changes.
|
Alrighty, let's merge this in. Thanks! |
This PR: