RW projects: Add resolutions for @types/react 17 #5112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs canceled.
|
Tobbe
force-pushed
the
tobbe-force-types-react-17
branch
from
8f1a26b to
8dc215c
Compare
Tobbe
force-pushed
the
tobbe-force-types-react-17
branch
from
8dc215c to
f2e0ea8
Compare
dac09
approved these changes
Apr 11, 2022
thedavidprice
added a commit
that referenced
this pull request
Apr 14, 2022
This reverts commit 7a1deb5.
|
Reverted in favor of #5165 |
thedavidprice
pushed a commit
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitely Typed recently released a new major version for react (and react-dom) types, to be used with React 18.
Some packages have a dependency on @types/react with the version set to "*". Those now causes the new, incompatible, types to be installed. This PR adds a
resolutionsfield to RW projects'package.jsonthat pins @types/react to 17.0.40.There's an issue on the Definitely Typed repo for this: DefinitelyTyped/DefinitelyTyped#59765
That issue is about @types/styled-components. In our case it seems to be @types/react-syntax-highlighter, but the issue is the same.
TODO:
Fixes #5104