fix(core): added undefined type successNotification and errorNotification

[Anonymous961]

Added undefined type to errorNotification and successNotification.

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

• Related issue(s) linked
• Tests for the changes have been added
• Docs have been added / updated
• Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

What is the current behavior?

What is the new behavior?

fixes #6270

Notes for reviewers

I followed the instructions provided by @aliemir in the issue discussion. Please let me know if any further changes are needed or if there are additional aspects I should address.

[changeset-bot]

🦋 Changeset detected

Latest commit: 2e25480

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@refinedev/core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[aliemir]

Hey @Anonymous961 thank you for the PR! Just checked it and looks like the change is correct but made in the wrong place 😅

undefined should be added to the return values of the function type of the union 😅

Sharing the lines below:

refine/packages/core/src/contexts/notification/types.ts

Lines 15 to 19 in 5a87542

	| ((
	data?: TData,
	values?: TVariables,
	resource?: string,
	) => OpenNotificationParams | false);

refine/packages/core/src/contexts/notification/types.ts

Lines 28 to 32 in 5a87542

	| ((
	error?: TError,
	values?: TVariables,
	resource?: string,
	) => OpenNotificationParams | false);

Line 19 and Line 32 should have undefined.

successNotification and errorNotification already has ? in their keys which makes them accept undefined already.

Let me know if you can apply the changes 🙏

[Anonymous961]

Ohh sorry my bad 😅 I just made the changes.

[aliemir]

Thank you for the update @Anonymous961 🙏 This PR will be included in our next release 🚀