Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(antd): update @ant-design/icons and @ant-design/pro-layout dependencies #6369

Merged
merged 15 commits into from
Nov 5, 2024

Conversation

aliemir
Copy link
Member

@aliemir aliemir commented Sep 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

Changes

After @ant-design/icons version 5.4.0 build issues and type issues are resolved. Following this release @ant-design/pro-layout also updated its dependency range to match the latest @ant-design/icons version.

Previously @ant-design/icons were pinned to 5.0.1 and recommended to pin in projects as well. After this update, you may also need to update the @ant-design/icons version in your project to match the latest version. (A range above ^5.5.1 is required to match @refinedev/antd).

resolves #6363
resolves #5931 - previously resolved by #5934
Accompanies #6354 - @ant-design/pro-layout also depends on express dependency and updated its version in the latest release

@aliemir aliemir requested a review from a team as a code owner September 24, 2024 12:44
Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: f951cbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@refinedev/antd Minor
@refinedev/inferencer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 24, 2024

@github-actions github-actions bot temporarily deployed to deploy-preview-invoicer-6369/merge September 24, 2024 12:47 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-antd-6369/merge September 24, 2024 12:47 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-pixels-6369/merge September 24, 2024 12:47 Inactive
@aliemir aliemir added this to the October Release milestone Sep 24, 2024
@aliemir aliemir linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link

cypress bot commented Sep 24, 2024

refine    Run #11608

Run Properties:  status check passed Passed #11608  •  git commit def1765d54 ℹ️: Merge fec8a695aaf0ce94af00ec240d7d1c80ca0a8cab into 61c809037235e85c3d79497b68ea...
Project refine
Branch Review chore/ant-design-dependency-bump
Run status status check passed Passed #11608
Run duration 16m 49s
Commit git commit def1765d54 ℹ️: Merge fec8a695aaf0ce94af00ec240d7d1c80ca0a8cab into 61c809037235e85c3d79497b68ea...
Committer Ali Emir Şen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 26
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 171
View all changes introduced in this branch ↗︎

@bombillazo
Copy link
Contributor

I was about to create a similar PR to bump pro-layout, glad to see this is already worked on. We are getting install/build warnings due to this:
image

Hopefully it can be merged soon.

@aliemir
Copy link
Member Author

aliemir commented Oct 7, 2024

Hey @bombillazo, due to the issues with lodash and lodash-es in the latest version of @ant-design/pro-layout we're waiting for a fix to be released. I've opened up a PR ant-design/pro-components#8754. As soon as this is merged and released, we'll include this PR to our release 🙏

Base automatically changed from releases/october to master October 14, 2024 12:54
@github-actions github-actions bot temporarily deployed to deploy-preview-pixels-6369/merge October 17, 2024 12:58 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-invoicer-6369/merge October 17, 2024 12:58 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-antd-6369/merge October 17, 2024 12:58 Inactive
@BatuhanW BatuhanW changed the base branch from master to releases/november October 28, 2024 09:48
@github-actions github-actions bot temporarily deployed to deploy-preview-invoicer-6369/merge October 28, 2024 09:51 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-pixels-6369/merge October 28, 2024 09:51 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-finefoods-antd-6369/merge October 28, 2024 09:51 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-invoicer-6369/merge November 5, 2024 08:57 Inactive
@github-actions github-actions bot temporarily deployed to deploy-preview-pixels-6369/merge November 5, 2024 08:57 Inactive
@aliemir aliemir merged commit def0dd9 into releases/november Nov 5, 2024
50 checks passed
@aliemir aliemir deleted the chore/ant-design-dependency-bump branch November 5, 2024 10:10
@BatuhanW BatuhanW mentioned this pull request Nov 7, 2024
BatuhanW pushed a commit that referenced this pull request Nov 7, 2024
- chore(chakra-ui): fix broken tsdoc links #6429 
- feat: export useInvalidateAuthStore hook #6405 Resolves #6341  
- feat(core): add `<MetaContext />` #6435 
- chore(antd): update @ant-design/icons and @ant-design/pro-layout dependencies #6369 Resolves #6363, #5931 
- feat(core,antd,mui,mantine,chakra-ui): add new prop to auth-page to p… #6432  Resolves #6431 
- fix(core): link component overrides to instead of go #6462 Resolves #6461 
- fix(react-hook-form): onChange handler autoSave check in useForm #6459 Resolves #6458 
- fix(core): link component ref type is too restrictive (#6464) Resolves #6463
@aliemir aliemir mentioned this pull request Nov 7, 2024
BatuhanW added a commit that referenced this pull request Nov 7, 2024
- chore(chakra-ui): fix broken tsdoc links #6429 
- feat: export useInvalidateAuthStore hook #6405 Resolves #6341  
- feat(core): add `<MetaContext />` #6435 
- chore(antd): update @ant-design/icons and @ant-design/pro-layout dependencies #6369 Resolves #6363, #5931 
- feat(core,antd,mui,mantine,chakra-ui): add new prop to auth-page to p… #6432  Resolves #6431 
- fix(core): link component overrides to instead of go #6462 Resolves #6461 
- fix(react-hook-form): onChange handler autoSave check in useForm #6459 Resolves #6458 
- fix(core): link component ref type is too restrictive (#6464) Resolves #6463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 3 high severity vulnerabilities [BUG] Named export 'SyncOutlined' not found.
5 participants