Domain Name based i18n : changes for sitemap & url localised #2280
Conversation
…:Refinery::I18n.domain_name_enabled? (domain name based i18n), edit sitemap to take in account localised domains
| # request appropriate host & port depending on i18n mode | ||
| localized_domain_name = ::Refinery::I18n.domain_name_for_locale(locale) | ||
| host_with_port = (::Refinery::I18n.domain_name_enabled? && localized_domain_name) ? | ||
| [localized_domain_name, ":", request.port].join : request.host_with_port |
There was a problem hiding this comment.
this should just be a lookup method that accepts request as an argument
|
@ugisozols want to give this a crack rebasing against 3.0.0.dev? 😉 |
|
@parndt are you happy with this implementation and think it should be part of Refinery? |
|
@ugisozols I am unsure.. I want the features but this PR got stale. |
|
Yeah, I'm unsure too so I'm leaning towards close button. |
|
@benxao are you still out there? |
|
Hi guys sorry for being quiet. I dont have much time now for working on
|
|
@ugisozols @simi keep or close? WDYT? |
|
keep |
|
@simi cool - what do you think of the implementation? |
|
I think that I do not know. |
|
@simi okay thanks 😁 |
|
I'm still unsure about this ... |
|
I'm willing to merge this functionality if someone takes over and re-implements it for 3.0.0 |
proposed changes for sitemap and page url localised for domain name enabled i18n
depends on
refinery/refinerycms-i18n#43