Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check exportability #146

Merged
merged 3 commits into from
Sep 11, 2023
Merged

check exportability #146

merged 3 commits into from
Sep 11, 2023

Conversation

jackie-pc
Copy link
Contributor

No description provided.

masenf
masenf reviewed Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we still need check_requirements as a separate workflow if we have this.

.github/workflows/check_export.yml Outdated
branches: [ main ]

jobs:
check-requirements:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
check-requirements:
check-export:

.github/workflows/check_export.yml Outdated
reflex init
reflex export
deactivate
if ls frontend.zip backend.zip; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible, we should check that these are valid zips as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure doing unzip -t is easy enough.

@jackie-pc jackie-pc marked this pull request as ready for review September 11, 2023 18:23
masenf
masenf approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the backend.zip supposed to contain the entire virtualenv?

@jackie-pc
Copy link
Contributor Author

Nope - it's one of the shortcomings of our reflex export --backend I was referring to before. IMO we need to implement smarting default logic plus some config knobs for overriding. E.g. for venvs.... we can do some heuristics to detect virtualenv dirs and exclude them, and have an --include configurable to bring it back if someone really knows they want it in there. Tracked here.

@jackie-pc jackie-pc merged commit b46b945 into main Sep 11, 2023
19 checks passed
@picklelo picklelo deleted the jackie-export branch October 9, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackie-pc @masenf