Sync with Refract Spec #45
Conversation
|
💥 💥 💥 💥 👯 |
| @@ -36,12 +36,12 @@ var el = { | |||
|
|
|||
| ## Usage | |||
|
|
|||
| ### Converting to Types | |||
| ### Converting to Elements | |||
There was a problem hiding this comment.
I feel like maybe this is more clear if we mention both the to and from:
Converting Javascript Values into Elements
There was a problem hiding this comment.
I think you are 100% correct
|
Generally I agree with this change, just a few minor points above! |
|
@danielgtaylor I've addressed comments. I'd like to squash some of these before merging, so let me know if it's good and I'll merge. Thanks! |
|
Other than that comment above I think this looks good. We'll need to take some time to update the downstream libraries like Fury. |
I'm going to be working on this a lot over the next few days. I'm wondering if it makes sense to wait until I'm finish (which will be the end of our sprint next Tuesday). |
|
Also, I sent out a document about some proposed changes for the API Description namespace. I think it would be good to wait on that, too, and fix it all at once. |
smizell
force-pushed
the
smizell/sync-with-spec
branch
from
c5a32c1 to
9e0ef74
Compare
chore: Release 0.9.2 to public npm
This handle issue #34.
This is kind of... nasty. But it aligns the code and terminology used through with the spec. This breaks every possible interface for the module :)
cc @danielgtaylor