Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are not actually parallel by default #32

Closed
dgunay opened this issue Aug 22, 2024 · 2 comments · Fixed by #33
Closed

Tests are not actually parallel by default #32

dgunay opened this issue Aug 22, 2024 · 2 comments · Fixed by #33

Comments

@dgunay
Copy link
Contributor

dgunay commented Aug 22, 2024

The docs say that tests are parallel by default, but Runner.parallel is never initialized to true anywhere in the codebase that I can find. We noticed that changing the code to do so sped our tests up a lot.

gocuke/runner.go

Line 62 in 8921eae

parallel: false,

@aaronc
Copy link
Member

aaronc commented Aug 22, 2024

Thanks for catching this error @dgunay ! Would you be able to push a small PR to fix it?

@dgunay dgunay mentioned this issue Aug 22, 2024
Merged
@dgunay
Copy link
Contributor Author

dgunay commented Aug 22, 2024

Thanks for catching this error @dgunay ! Would you be able to push a small PR to fix it?

Sure: #33

@aaronc aaronc closed this as completed in ae1ad2e Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: actually set parallel to true by default dgunay/gocuke
2 participants
@aaronc @dgunay