Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actually set parallel to true by default #33

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

dgunay
Copy link
Contributor

@dgunay dgunay commented Aug 22, 2024

Resolves #32

@aaronc aaronc changed the title Actually set parallel to true by default fix: actually set parallel to true by default Aug 22, 2024
@aaronc
Copy link
Member

aaronc commented Aug 22, 2024

Seems like there are some tests that fail I'm assuming because they actually don't work in parallel mode (haven't had a chance to check in detail yet). So we need to explicitly disable parallel in those tests.

I wonder if for tagging this release it's okay to just do a minor or patch version bump with a warning that upgrading may break some tests that depended on this bug.

@dgunay
Copy link
Contributor Author

dgunay commented Aug 23, 2024

Seems like there are some tests that fail I'm assuming because they actually don't work in parallel mode (haven't had a chance to check in detail yet). So we need to explicitly disable parallel in those tests.

I wonder if for tagging this release it's okay to just do a minor or patch version bump with a warning that upgrading may break some tests that depended on this bug.

I'll leave that up to you. I've marked the tests non parallel.

In case you aren't aware, the test suite also trips the race detector in several places.

@aaronc
Copy link
Member

aaronc commented Aug 23, 2024

In case you aren't aware, the test suite also trips the race detector in several places.

Okay, thanks for letting me know! I'll create a separate issue for that. I think let's merge this now, but I want to fix those issues before tagging a new release. It looks like some of these issues could be problematic in parallel execution.

@aaronc aaronc merged commit ae1ad2e into regen-network:main Aug 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are not actually parallel by default
2 participants