Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: additional usage examples #18

Merged
merged 1 commit into from
Nov 21, 2023
Merged

chore: additional usage examples #18

merged 1 commit into from
Nov 21, 2023

Conversation

0xste
Copy link
Collaborator

@0xste 0xste commented Nov 17, 2023

Had a stab at the following issues:

Additionally:

  • Got rid of some linting errors from pre-commit hooks
  • Couple of instances of shadowing, file access etc, largely minor

@0xste 0xste marked this pull request as ready for review November 18, 2023 00:01
aaronc
aaronc approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why _example as opposed to just example?

@aaronc
Copy link
Member

aaronc commented Nov 20, 2023

Btw, sent you a DM on LinkedIn. Would you like to be added as a maintainer @0xste ?

@0xste
Copy link
Collaborator Author

0xste commented Nov 20, 2023

@aaronc id aligned _examples with what’s in the Godog implementation

@0xste 0xste merged commit 4e290f5 into regen-network:main Nov 21, 2023
2 checks passed
@0xste 0xste mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronc aaronc aaronc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xste @aaronc @stefano-bd