fix: all_ecocredit_txes to use msg.data->@type instead of msg_event.type
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blushi
changed the title
all_ecocredit_txes to use msg.data->@type instead of msg_event.type
aaronc
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #55
The
all_ecocredit_txespg function - that we rely on on the front-end to display the activity table: https://app.regen.network/stats/activity which is msg-based - was using a join on themsg_eventtable instead of themsgtable.For certain msgs, multiple events can be emitted (eg for
MsgBuyDirect:EventBuyDirect,EventRetireandEventTransfercan be emitted). This is why we could see the same row multiple times in the Activity table.I've deployed to the indexer staging heroku app and db, which is used on https://dev.app.regen.network/stats/activity and now works as expected.