-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit)!: implement independent projects #2167
base: main
Are you sure you want to change the base?
Changes from 114 commits
89e7630
c54af2a
d98b364
78d71e1
cf50830
0139192
4a7370e
f4146a3
864c63b
7f0af0d
f6d3f93
041af55
ea41f12
c3c15cd
d13c13c
809c089
fe74b46
1798de5
b571c1f
ad6b522
a03d165
4c81f78
89e986f
222a6af
d5feae9
4921fbe
84ac1a4
5faa1ae
72f1d54
8e58525
fc61689
5450d06
2e523c8
53fbaf6
5faccb5
9bbe3eb
7008513
81ef202
b2ad50c
0d98f57
8d0cbb4
33afc48
bff1c32
fe45d70
75616f9
18c0c7f
b29c249
e7aa7be
65a9758
6fabbf7
ea8f17b
fa5a465
6e60592
a5aa435
0aabd0b
84ba6f9
8a18b1a
1657932
8d6299f
c00ce61
c952a45
19c4aff
e97f26f
7fdcf70
8f0840d
b365045
6c837f6
7b37ed0
d089a80
a135011
7279a19
17362c0
454d7d4
47507e1
86a4180
d047dd7
cc428ad
48a9dc7
cafe075
b3a7eb3
497de7b
38b631a
4aff001
a53fe68
5d5249e
ab7cc06
5724801
29f659b
f4fd66a
2b8e175
d6e0b78
65f60c7
356a2ff
b0cfdb7
c262750
4336def
7c6fdb2
728919f
9fdd3fc
146ffb7
9c208b4
27700ae
171c661
5687db8
92ceeec
9f9f9cc
3a5c295
2de0250
d25eebf
5146a89
fd96f71
c4b8c76
1216bbd
26b1f22
f1968c5
dc4f235
75a7dfe
8fd6b93
27bca17
389ace5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,8 @@ | |
// CreateOrUpdateApplicaton creates a new project credit class application, updates | ||
// the metadata for an existing one when changes have been requested, or withdraws | ||
// the application. When an application is withdrawn, its data will be deleted from | ||
// state and the project may apply again to the same credit class in the future. | ||
// state and the project may apply again to the same credit class in the future. Any | ||
// new metadata will be passed to EventUpdateApplication including for withdrawals. | ||
// | ||
// Since Revision 3 | ||
rpc CreateOrUpdateApplication(MsgCreateOrUpdateApplication) | ||
|
@@ -157,8 +158,8 @@ | |
// the scope of the provided credit class, the credits will be minted to the | ||
// existing credit batch, otherwise the credits will be issued in a new credit | ||
// batch. The new credit batch will be created under an existing project if a | ||
// project with a matching reference id already exists within the scope of the | ||
// credit class, otherwise a new project will be created. | ||
// project with a matching reference id already exists, otherwise a new project | ||
// will be created. | ||
Comment on lines
-160
to
+162
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why remove this text from the comment? Isn't it still true uniqueness of reference_id is only enforced within the scope of a credit class? |
||
rpc BridgeReceive(MsgBridgeReceive) returns (MsgBridgeReceiveResponse); | ||
|
||
// AddCreditType is a governance method that allows the addition of new | ||
|
@@ -328,7 +329,7 @@ | |
} | ||
|
||
// MsgCreateUnregisteredProject is the Msg/CreateUnregisteredProject request type. | ||
message MsgCreateUnregisteredProject { | ||
option (cosmos.msg.v1.signer) = "admin"; | ||
|
||
// admin is the address of the account creating the project that will become | ||
|
@@ -348,16 +349,12 @@ | |
// increased precision. | ||
string jurisdiction = 3; | ||
|
||
// reference_id is any arbitrary string used to reference the project with a | ||
// maximum length of 32 characters. | ||
string reference_id = 4; | ||
|
||
// fee is the project creation fee. An equal fee is required if the project | ||
// creation fee parameter is set. The provided fee can be greater than the | ||
// parameter, but only the amount in the parameter will be charged. | ||
// | ||
// Since Revision 3 | ||
cosmos.base.v1beta1.Coin fee = 5; | ||
cosmos.base.v1beta1.Coin fee = 4; | ||
Check failure on line 357 in proto/regen/ecocredit/v1/tx.proto GitHub Actions / break-check
Check failure on line 357 in proto/regen/ecocredit/v1/tx.proto GitHub Actions / break-check
Check failure on line 357 in proto/regen/ecocredit/v1/tx.proto GitHub Actions / break-check
|
||
} | ||
|
||
// MsgCreateUnregisteredProjectResponse is the Msg/CreateUnregisteredProject response type. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way for the GET request to support no
project_id
, such that it queries all project enrollments? Also, is there a way to optionally filter byclass_id
in the grpc-gateway path?Would be nice to accommodate those use cases if possible.