Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: devnet for regen-ledger #2224

Conversation

PJEstrada
Copy link

@PJEstrada PJEstrada commented Oct 18, 2024

Description

Adds a Devnet script using docker compose for running tests against a local network.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)__

@JeancarloBarrios
Copy link
Member

JeancarloBarrios commented Oct 18, 2024

@PJEstrada I think it LGTM lets just parametrized the validator number, and genesis file

@JeancarloBarrios JeancarloBarrios changed the title feat: Devnet cosmos sdk 047 feat: Devnet regen-ldeger Oct 18, 2024
@JeancarloBarrios JeancarloBarrios changed the title feat: Devnet regen-ldeger feat: devnet for regen-ldeger Oct 18, 2024
@PJEstrada PJEstrada changed the title feat: devnet for regen-ldeger feat: devnet for regen-ledeger Oct 18, 2024
@PJEstrada PJEstrada changed the title feat: devnet for regen-ledeger feat: devnet for regen-ledger Oct 18, 2024
Copy link

@Moo12332 Moo12332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@JeancarloBarrios JeancarloBarrios marked this pull request as ready for review October 21, 2024 20:40
Copy link
Member

@JeancarloBarrios JeancarloBarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the parametrization, and we are good!!

@PJEstrada
Copy link
Author

Let's add the parametrization, and we are good!!

Thanks @JeancarloBarrios ! I've added parametrization of node count here fe5d0bd

For the initial state my suggestion for now is to rely on the CLI to create state init scripts, mainly because the dynamic creation of the keys between on each start makes the genesis file generation a bit more complex. As this devenet gets more usage we can evaluate if it's worth adding tooling around genesis file state generation for better developer ergonomics

@JeancarloBarrios JeancarloBarrios merged commit 32a02e9 into regen-network:robert/cosmos-sdk-047 Oct 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants