Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upstream ORM updates #886

Merged
merged 6 commits into from
Mar 15, 2022
Merged

chore: upstream ORM updates #886

merged 6 commits into from
Mar 15, 2022

Conversation

technicallyty
Copy link
Contributor

Description

bumps ORM version to alpha.11 which includes a codegen change with table postfixes changing from Store to Table and bug fixes.

Closes: n/a


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@@ -139,8 +139,6 @@ replace google.golang.org/grpc => google.golang.org/grpc v1.33.2

replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

replace github.com/tecbot/gorocksdb => github.com/cosmos/gorocksdb v1.2.0
Copy link
Contributor Author

@technicallyty technicallyty Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go mod tidy was failing from this line.. dont think we actually needed it tho?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm.... #677

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after looking at it again, i realized we already have cosmos/gorocksdb under the require so no need to replace it anymore

@technicallyty technicallyty marked this pull request as draft March 14, 2022 23:31
@technicallyty technicallyty marked this pull request as ready for review March 15, 2022 00:14
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #886 (ac80d48) into master (6588f5b) will increase coverage by 0.00%.
The diff coverage is 60.79%.

❗ Current head ac80d48 differs from pull request most recent head 0902507. Consider uploading reports for the commit 0902507 to get more accurate results

@@           Coverage Diff           @@
##           master     #886   +/-   ##
=======================================
  Coverage   27.44%   27.44%           
=======================================
  Files         195      195           
  Lines       72193    72186    -7     
=======================================
+ Hits        19812    19813    +1     
+ Misses      50646    50639    -7     
+ Partials     1735     1734    -1     
Flag Coverage Δ
experimental-codecov 27.42% <60.79%> (+<0.01%) ⬆️
stable-codecov 24.06% <60.79%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo enabled auto-merge (squash) March 15, 2022 14:56
@ryanchristo ryanchristo merged commit 888f8a5 into master Mar 15, 2022
@ryanchristo ryanchristo deleted the ty/na-upstream_orm_updates branch March 15, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants