feat: Credit Class Page "Additional Info" improvements #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ryanchristo
approved these changes
Jul 25, 2023
Comment on lines
+30
to
+31
| // We probably want to simplify this to be just a @list instead, | ||
| // but keeping as is, until C04 class metadata is updated accordingly. |
There was a problem hiding this comment.
Should we create a followup task blocked by regen-network/regen-registry-standards#57?
Comment on lines
+39
to
+41
| // Keeping both regen:walletAddress and regen:address for now, | ||
| // until C04 class metadata gets fixed. | ||
| // But ultimately, we should just use regen:address. |
There was a problem hiding this comment.
Also relevant to regen-network/regen-registry-standards#57
blushi
commented
Jul 26, 2023
| if (isString || isNumber) { | ||
| if (isNumber) { | ||
| formattedValue = formatNumber({ num: value }); | ||
| } else if (rdfType === 'xsd:date') { | ||
| formattedValue = formatDate(value); | ||
| } else if (rdfType?.includes('Duration')) { |
There was a problem hiding this comment.
currently just "Duration" inclusion checking this but ultimately once this: regen-network/regen-registry-standards#57 (comment) is fixed, we should check for schema:Duration equality
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: regen-network/rnd-dev-team#1756
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
https://deploy-preview-1980--regen-registry.netlify.app/credit-classes/C62
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...