feat: add react-native support #47
Conversation
| }, | ||
| } | ||
| : { | ||
| onPress(evt: any) { |
There was a problem hiding this comment.
any is not acceptable, please specify event type.
| @@ -2,6 +2,7 @@ import { MouseEvent } from 'react'; | |||
|
|
|||
| export interface DPPropsGetterConfig extends Record<string, unknown> { | |||
| onClick?(evt?: MouseEvent<HTMLElement>, date?: Date): void; | |||
| onPress?(evt?: any, date?: Date): void; | |||
There was a problem hiding this comment.
any is not acceptable.
Why we need to add additional prop on top of onClick for ReactNative. Why can't we pass onClick: onPress?
There was a problem hiding this comment.
just wanted to avoid dependency to react native.
or maybe we can copy GestureResponderEvent from react native ?
There was a problem hiding this comment.
onClick is not working in react native so using onPress is common, although here onClick will also work. but to avoid confusion included onPress as well.
There was a problem hiding this comment.
Better to add react-native to the pearDependencies and specify type.
| @@ -12,4 +13,5 @@ export interface DPPropGetter extends Record<string, unknown> { | |||
| 'aria-disabled'?: boolean; | |||
| 'aria-selected'?: boolean; | |||
| onClick?(evt: MouseEvent<HTMLElement>): void; | |||
| onPress?(evt: any): void; | |||
| export const isWeb = false; | ||
| export const isNative = true; |
There was a problem hiding this comment.
How will it work, react automatically will pick platform.native.ts or platform.ts based on ReactNavite or not?
Since this is buildable package I can't see how it will work, (I'm not an expert in React Native).
There was a problem hiding this comment.
yeah bundlers will handle that file. and builded artifact also include that.
so on react native it only resolves .native file
There was a problem hiding this comment.
I thought we need to create a separate build for the React Native
|
Closing because it seems like this feature will not work without changes to the bundling system |
No description provided.