Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing e2e #193

Merged
merged 13 commits into from
Dec 10, 2024
Merged

testing e2e #193

merged 13 commits into from
Dec 10, 2024

Conversation

sikhote
Copy link
Contributor

@sikhote sikhote commented Dec 9, 2024

Description

  • Moved all e2e testing to Playwright, moving away from Nightwatch
  • No longer needed the e2e page, just using the kitchen sink page

Why

Tests were failing with Nightwatch and I could not find any support as to why. It worked last Friday. Playwright seems much more supported and the current standard.

@sikhote sikhote self-assigned this Dec 9, 2024
@sikhote sikhote marked this pull request as ready for review December 9, 2024 22:15
Copy link
Member

@mhewson mhewson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I do like the interface for generating the playwright report tho I did create a reports dir for the linting work - I wonder if we can store these together to ensure we capture a full backlog of regressions that need to be managed?

@sikhote sikhote merged commit eeb1f87 into main Dec 10, 2024
3 checks passed
@sikhote sikhote deleted the main-test branch December 10, 2024 19:43
@sikhote
Copy link
Contributor Author

sikhote commented Dec 10, 2024

I think the linting work will be much more important. For the playwright reports, to me they are "throw away", because any issues they catch should be fixed before merging a PR. Any reports they produce are not really helpful until there is an issue...but maybe that's just me 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants