torii: validate events (starkware-libs#1100)

reilabs · Oct 31, 2023 · f02b313 · f02b313
1 parent 5a2a5df
commit f02b313
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 1 deletion.
diff --git a/crates/torii/core/src/engine.rs b/crates/torii/core/src/engine.rs
@@ -245,7 +245,9 @@ where
     ) -> Result<()> {
         self.db.store_event(event_id, event, invoke_receipt.transaction_hash);
         for processor in &self.processors.event {
-            if get_selector_from_name(&processor.event_key())? == event.keys[0] {
+            if get_selector_from_name(&processor.event_key())? == event.keys[0]
+                && processor.validate(event)
+            {
                 processor
                     .process(&self.world, self.db, block, invoke_receipt, event_id, event)
                     .await?;

diff --git a/crates/torii/core/src/processors/metadata_update.rs b/crates/torii/core/src/processors/metadata_update.rs
@@ -21,6 +21,18 @@ where
         "MetadataUpdate".to_string()
     }
 
+    fn validate(&self, event: &Event) -> bool {
+        if event.keys.len() > 1 {
+            info!(
+                "invalid keys for event {}: {}",
+                <MetadataUpdateProcessor as EventProcessor<P>>::event_key(self),
+                <MetadataUpdateProcessor as EventProcessor<P>>::event_keys_as_string(self, event),
+            );
+            return false;
+        }
+        true
+    }
+
     async fn process(
         &self,
         _world: &WorldContractReader<P>,

diff --git a/crates/torii/core/src/processors/mod.rs b/crates/torii/core/src/processors/mod.rs
@@ -18,6 +18,12 @@ where
 {
     fn event_key(&self) -> String;
 
+    fn event_keys_as_string(&self, event: &Event) -> String {
+        event.keys.iter().map(|i| format!("{:#064x}", i)).collect::<Vec<_>>().join(",")
+    }
+
+    fn validate(&self, event: &Event) -> bool;
+
     #[allow(clippy::too_many_arguments)]
     async fn process(
         &self,

diff --git a/crates/torii/core/src/processors/register_model.rs b/crates/torii/core/src/processors/register_model.rs
@@ -22,6 +22,18 @@ where
         "ModelRegistered".to_string()
     }
 
+    fn validate(&self, event: &Event) -> bool {
+        if event.keys.len() > 1 {
+            info!(
+                "invalid keys for event {}: {}",
+                <RegisterModelProcessor as EventProcessor<P>>::event_key(self),
+                <RegisterModelProcessor as EventProcessor<P>>::event_keys_as_string(self, event),
+            );
+            return false;
+        }
+        true
+    }
+
     async fn process(
         &self,
         world: &WorldContractReader<P>,

diff --git a/crates/torii/core/src/processors/store_set_record.rs b/crates/torii/core/src/processors/store_set_record.rs
@@ -26,6 +26,18 @@ where
         "StoreSetRecord".to_string()
     }
 
+    fn validate(&self, event: &Event) -> bool {
+        if event.keys.len() > 1 {
+            info!(
+                "invalid keys for event {}: {}",
+                <StoreSetRecordProcessor as EventProcessor<P>>::event_key(self),
+                <StoreSetRecordProcessor as EventProcessor<P>>::event_keys_as_string(self, event),
+            );
+            return false;
+        }
+        true
+    }
+
     async fn process(
         &self,
         world: &WorldContractReader<P>,