This repository has been archived by the owner on Jul 13, 2022. It is now read-only.
Raise error so 404 is triggered when URL is wrong #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Record.find_by_x doesn't raise an ActiveRecord::RecordNotFound error, which triggers the 404, so our app was returning a 500 error when incorrect district URLs were accessed. (e.g. /d/san-francisco-sdf). This should protect against that (but only in hosted environments)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record.find_by_x doesn't raise an ActiveRecord::RecordNotFound error,
which triggers the 404, so our app was returning a 500 error when
incorrect district URLs were accessed. (e.g. /d/san-francisco-sdf). This
should protect against that (but only in hosted environments)
We could still use a nice 404 page—right now we use the Rails default.
#80