Go version up #31
Open
Go version up #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The topics of this PR will be covered in the long-term by issue #29. I leave it open till the upgrade to kubebuilder/v4 and close them together. No further action will be taken here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up go version to 1.23
go mod edit -go 1.23go mod tidyThis update mainly fixes the issue with loop variable reference https://go.dev/blog/loopvar-preview
I noticed some loop variable references in
controllers/sleepcycle_finalizers.goand thought upgrading the Go version might be a good idea anyway.